fix(cli): derive package name from project directory#2564
Closed
Will-thom wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes the interactive package name prompt from the project creation flow, deriving the package name from the resolved project directory instead.
Changes:
- Drops
getPackageNameandisValidPackageNamefrominputs.ts. - Uses
path.basename(root)as the package name increate.ts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/typegpu-cli/src/utils/inputs.ts | Removes unused getPackageName helper and its validator. |
| packages/typegpu-cli/src/create.ts | Replaces interactive package name input with directory basename. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const root = await prepareDirectory(cwd, projectDir); | ||
|
|
||
| const packageName = await getPackageName(projectDir); | ||
| const packageName = path.basename(root); |
Contributor
|
Done in #2565 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2543
Tests
Note: local Node is v22.21.1, while the repo asks for >=24.0.0; commands completed with the engine warning.